consider deleted string contents when updating outdated translations

sitegeist · Jan 22, 2024 · 49d1c35 · 49d1c35
1 parent 3b5e8d4
commit 49d1c35
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/Classes/Ui/Changes/UpdateOutdatedTranslations.php b/Classes/Ui/Changes/UpdateOutdatedTranslations.php
@@ -45,7 +45,10 @@ public function apply()
             foreach ($translatableProperties as $translatableProperty) {
                 $name = $translatableProperty->getName();
                 $value = $referenceNode->getProperty($name);
-                if (!empty($value) && is_string($value) && strip_tags($value) !== '') {
+                if (
+                    is_string($value)
+                    && (!empty($value) || !empty($node->getProperty($name) ?: ''))
+                ) {
                     $propertiesToTranslate[$name] = $value;
                 }
             }

diff --git a/Resources/Private/Fusion/Frontend/Collection/InfoRenderer.fusion b/Resources/Private/Fusion/Frontend/Collection/InfoRenderer.fusion
@@ -31,7 +31,7 @@ prototype(Sitegeist.LostInTranslation:Collection.TranslationInformation) < proto
                             Missing Contents: <Neos.Fusion:Loop items={props.status.missing} @glue=", ">{item.node.label}</Neos.Fusion:Loop>
                         </p>
                         <p @if={props.status.outdated}>
-                            Outdated Contents: <Neos.Fusion:Loop items={props.status.outdated}>{item.node.label}</Neos.Fusion:Loop>
+                            Outdated Contents: <Neos.Fusion:Loop items={props.status.outdated} @glue=", ">{item.node.label}</Neos.Fusion:Loop>
                         </p>
                     </Neos.Fusion:Fragment>
                 </lost-in-translation-info>

diff --git a/Resources/Private/Fusion/Frontend/Document/InfoRenderer.fusion b/Resources/Private/Fusion/Frontend/Document/InfoRenderer.fusion
@@ -30,7 +30,7 @@ prototype(Sitegeist.LostInTranslation:Document.TranslationInformation) < prototy
                             Missing Contents: <Neos.Fusion:Loop items={props.status.missing} @glue=", ">{item.node.label}</Neos.Fusion:Loop>
                         </p>
                         <p @if={props.status.outdated}>
-                            Outdated Contents: <Neos.Fusion:Loop items={props.status.outdated}>{item.node.label}</Neos.Fusion:Loop>
+                            Outdated Contents: <Neos.Fusion:Loop items={props.status.outdated}  @glue=", ">{item.node.label}</Neos.Fusion:Loop>
                         </p>
                     </Neos.Fusion:Fragment>
                 </lost-in-translation-info>