Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing of Stack for TypeScript 3.9.2 #398

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nechutny
Copy link

@nechutny nechutny commented Aug 4, 2020

Hello, when using pnotify with project in typesciprt 3.9.2 I've got error

[at-loader] ./node_modules/@pnotify/core/Stack.d.ts:121:21 
    TS2709: Cannot use namespace 'Notice' as a type. 

[at-loader] ./node_modules/@pnotify/core/Stack.d.ts:130:20 
    TS2709: Cannot use namespace 'Notice' as a type. 

[at-loader] ./node_modules/@pnotify/core/Stack.d.ts:142:25 
    TS2709: Cannot use namespace 'Notice' as a type. 

[at-loader] ./node_modules/@pnotify/core/Stack.d.ts:149:14 
    TS2709: Cannot use namespace 'Notice' as a type. ```

So I've prepared fix for this - use proper typeof in Stack.d.ts

@irving-caamal
Copy link

these seem very useful, up.

@SeanPlane-dev
Copy link

I'm experiencing this issue too. This fix would be greatly appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants