You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This might not be a perfect fix but it takes care of the compile-time errors for my angular application.
node_modules/@pnotify/core/Stack.d.ts you will have to modify line 1 to import { Notice } from './';
replace line 193 to 208 with the code below swap( one: Notice, theOther: Notice, immediate: boolean, waitAfter: boolean ): Promise<unknown>;
replace line 220 with the following fire(event: string, detail: {}): void;
In @pnotify/core/index.d.ts file replace line 250 with open(immediate?: boolean): Promise<unknown>; and replace line 261 to 265 with close( immediate?: boolean, timerHide?: boolean, waitAfterward?: boolean ): Promise<unknown>;
This fix worked for "pnotify": "^5.2.0", hopefully the next update will fix these error. Ummmm you might have to redo this again if you reinstall the same package.
The text was updated successfully, but these errors were encountered:
Hey just wanted to +1 this issue because I'm experiencing the exact same compile time error. For additional context, we're currently using TypeScript v4.3.0 (we're also working on an Angular codebase. I know that was mentioned in #388, although I don't believe the fact that we're using Angular is relevant to this issue).
It seems like there's been an open PR to address this issue here: #398, although the changes in that PR and the changes suggested in this issue are quite different.
I believe the suggestions in this issue are more correct, because in one of the TypeScript errors about Promise (as alluded to by @samuelsonokoi above), it's specifically saying that the generic type Promise requires one type argument.
@hperrin Anything we can do to assist? Possibly open a PR with the changes suggested here?
This might not be a perfect fix but it takes care of the compile-time errors for my angular application.
node_modules/@pnotify/core/Stack.d.ts
you will have to modify line 1 toimport { Notice } from './';
replace line 193 to 208 with the code below
swap( one: Notice, theOther: Notice, immediate: boolean, waitAfter: boolean ): Promise<unknown>;
replace line 220 with the following
fire(event: string, detail: {}): void;
In
@pnotify/core/index.d.ts file
replace line 250 withopen(immediate?: boolean): Promise<unknown>;
and replace line 261 to 265 withclose( immediate?: boolean, timerHide?: boolean, waitAfterward?: boolean ): Promise<unknown>;
This fix worked for
"pnotify": "^5.2.0",
hopefully the next update will fix these error. Ummmm you might have to redo this again if you reinstall the same package.The text was updated successfully, but these errors were encountered: