Skip to content

Commit

Permalink
Capitalize accessibility identifier for back button
Browse files Browse the repository at this point in the history
Before, the accessibility label was "back". Now it is "Back". This is done to
make unification of strings easier, as I don't want to have both strings to say
the same thing. Also, all other accessibility labels start with a capital
letter.

Done in tandem with the snapshot test fix[1].

MOB-2538

[1]: https://github.com/salemove/ios-widgets-snapshots/pull/37
  • Loading branch information
gersonnoboa committed Aug 25, 2023
1 parent 801e169 commit d3e294f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions GliaWidgets/L10n.swift
Original file line number Diff line number Diff line change
Expand Up @@ -544,8 +544,8 @@ public enum L10n {
public enum BackButton {
///
public static let hint = L10n.tr("Deprecated", "chat.accessibility.header.backButton.hint", fallback: "")
/// back
public static let label = L10n.tr("Deprecated", "chat.accessibility.header.backButton.label", fallback: "back")
/// Back
public static let label = L10n.tr("Deprecated", "chat.accessibility.header.backButton.label", fallback: "Back")
}
public enum CloseButton {
///
Expand Down
2 changes: 1 addition & 1 deletion GliaWidgets/Resources/en.lproj/Deprecated.strings
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
"chat.accessibility.message.choiceCard.buttonState.normal" = "";
"chat.accessibility.message.choiceCard.buttonState.selected" = "Selected";
"chat.accessibility.message.choiceCard.buttonState.disabled" = "Disabled";
"chat.accessibility.header.backButton.label" = "back";
"chat.accessibility.header.backButton.label" = "Back";
"chat.accessibility.header.backButton.hint" = "";
"chat.accessibility.header.endButton.label" = "End";
"chat.accessibility.header.closeButton.label" = "Close";
Expand Down

0 comments on commit d3e294f

Please sign in to comment.