Skip to content

Commit

Permalink
Update strings to ensure successful snapshot tests
Browse files Browse the repository at this point in the history
Three strings have changed:

* "we are" instead of "we're".
* Asterisk has the space removed.
* "we will" instead of "we'll"

The changes in which the longer version is used were done because Android
doesn't like quotes on strings, so they had to use escaping or something like
that, but iOS doesn't have that issue, however we would still need to have
escaped strings. Thus we have just removed all quotes. The asterisk space was
removed because it is viewing logic, so it shouldn't be in the string.

MOB-2538
  • Loading branch information
gersonnoboa committed Aug 23, 2023
1 parent 94f76c8 commit 801e169
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
16 changes: 8 additions & 8 deletions GliaWidgets/L10n.swift
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,8 @@ public enum L10n {
}
}
public enum Call {
/// You can continue browsing and we’ll connect you automatically.
public static let bottomText = L10n.tr("Deprecated", "call.bottomText", fallback: "You can continue browsing and we’ll connect you automatically.")
/// You can continue browsing and we will connect you automatically.
public static let bottomText = L10n.tr("Deprecated", "call.bottomText", fallback: "You can continue browsing and we will connect you automatically.")
/// (By default your video will be off)
public static let topText = L10n.tr("Deprecated", "call.topText", fallback: "(By default your video will be off)")
public enum Accessibility {
Expand Down Expand Up @@ -401,8 +401,8 @@ public enum L10n {
public enum Queue {
/// CompanyName
public static let firstText = L10n.tr("Deprecated", "call.connect.queue.firstText", fallback: "CompanyName")
/// We're here to help!
public static let secondText = L10n.tr("Deprecated", "call.connect.queue.secondText", fallback: "We're here to help!")
/// We are here to help!
public static let secondText = L10n.tr("Deprecated", "call.connect.queue.secondText", fallback: "We are here to help!")
}
public enum Transferring {
/// Transferring
Expand Down Expand Up @@ -645,8 +645,8 @@ public enum L10n {
public enum Queue {
/// CompanyName
public static let firstText = L10n.tr("Deprecated", "chat.connect.queue.firstText", fallback: "CompanyName")
/// We're here to help!
public static let secondText = L10n.tr("Deprecated", "chat.connect.queue.secondText", fallback: "We're here to help!")
/// We are here to help!
public static let secondText = L10n.tr("Deprecated", "chat.connect.queue.secondText", fallback: "We are here to help!")
}
public enum Transferring {
/// Transferring
Expand Down Expand Up @@ -869,8 +869,8 @@ public enum L10n {
}
public enum Question {
public enum Title {
/// *
public static let asterisk = L10n.tr("Deprecated", "survey.question.title.asterisk", fallback: " *")
/// *
public static let asterisk = L10n.tr("Deprecated", "survey.question.title.asterisk", fallback: "*")
}
}
}
Expand Down
8 changes: 4 additions & 4 deletions GliaWidgets/Resources/en.lproj/Deprecated.strings
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"chat.title" = "Chat";
"chat.endButton.title" = "End";
"chat.connect.queue.firstText" = "CompanyName";
"chat.connect.queue.secondText" = "We're here to help!";
"chat.connect.queue.secondText" = "We are here to help!";
"chat.connect.connecting.firstText" = "Connecting with {operatorName}";
"chat.connect.connecting.secondText" = "";
"chat.connect.connected.firstText" = "{operatorName}";
Expand Down Expand Up @@ -143,15 +143,15 @@
"call.video.title" = "Video";
"call.endButton.title" = "End";
"call.connect.queue.firstText" = "CompanyName";
"call.connect.queue.secondText" = "We're here to help!";
"call.connect.queue.secondText" = "We are here to help!";
"call.connect.connecting.firstText" = "Connecting with {operatorName}";
"call.connect.connecting.secondText" = "";
"call.connect.connected.firstText" = "{operatorName}";
"call.connect.connected.secondText" = "{callDuration}";
"call.connect.transferring.firstText" = "Transferring";
"call.operator.name" = "{operatorName}";
"call.topText" = "(By default your video will be off)";
"call.bottomText" = "You can continue browsing and we’ll connect you automatically.";
"call.bottomText" = "You can continue browsing and we will connect you automatically.";
"call.buttons.chat.title" = "Chat";
"call.buttons.video.title" = "Video";
"call.buttons.mute.inactive.title" = "Mute";
Expand Down Expand Up @@ -214,7 +214,7 @@
"survey.action.yes" = "Yes";
"survey.action.no" = "No";
"survey.action.validationError" = "Please provide an answer.";
"survey.question.title.asterisk" = " *";
"survey.question.title.asterisk" = "*";

"survey.accessibility.footer.cancelButton.label" = "Cancel";
"survey.accessibility.footer.submitButton.label" = "Submit";
Expand Down

0 comments on commit 801e169

Please sign in to comment.