Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout value in std output #1807

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

fmauch
Copy link
Contributor

@fmauch fmauch commented Oct 22, 2024

We were using the wrong timeout in the terminal output there.

As pointed out in #1501 (comment)

Thanks @tonynajjar for spotting this!

We were using the wrong timeout in the terminal output there.
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.60%. Comparing base (d55def1) to head (990ea72).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1807      +/-   ##
==========================================
- Coverage   87.62%   87.60%   -0.02%     
==========================================
  Files         120      120              
  Lines       12217    12223       +6     
  Branches     1093     1093              
==========================================
+ Hits        10705    10708       +3     
- Misses       1123     1125       +2     
- Partials      389      390       +1     
Flag Coverage Δ
unittests 87.60% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../controller_manager/controller_manager_services.py 74.62% <ø> (ø)

... and 6 files with indirect coverage changes

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants