Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow extra spawner arguments to not declare every argument in launch utils (backport #1505) #1792

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 13, 2024

This PR allows the users to parser extra spawner arguments without having to redeclare everything again in the launch utils


This is an automatic backport of pull request #1505 done by Mergify.

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.36%. Comparing base (847e655) to head (28e0b91).
Report is 1 commits behind head on humble.

Files with missing lines Patch % Lines
...troller_manager/controller_manager/launch_utils.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1792      +/-   ##
==========================================
- Coverage   62.37%   62.36%   -0.02%     
==========================================
  Files         108      108              
  Lines       11407    11409       +2     
  Branches     7978     7982       +4     
==========================================
  Hits         7115     7115              
- Misses        815      817       +2     
  Partials     3477     3477              
Flag Coverage Δ
unittests 62.36% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...troller_manager/controller_manager/launch_utils.py 0.00% <0.00%> (ø)

@christophfroehlich christophfroehlich merged commit d3de746 into humble Oct 13, 2024
11 of 12 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-1505 branch October 13, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants