Small improvements to the error output in component parser to make debugging easier. #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
arne48,
erickisos,
moriarty and
peterdavidfagan
bmagyar
previously approved these changes
Jun 19, 2024
bmagyar
added
backport-humble
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1580 +/- ##
=======================================
Coverage 87.70% 87.70%
=======================================
Files 102 102
Lines 8704 8704
Branches 780 780
=======================================
Hits 7634 7634
Misses 790 790
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
|
christophfroehlich
added a commit
that referenced
this pull request
Jul 13, 2024
…bugging easier. (backport #1580) (#1581) * Small improvements to the error output in component parser to make debugging easier. (#1580) * Small improvements to the error output in component parser to make debugging easier. * Correct formatting. (cherry picked from commit fbb893b) # Conflicts: # hardware_interface/src/component_parser.cpp * Fix merge conflict --------- Co-authored-by: Dr. Denis <[email protected]> Co-authored-by: Christoph Froehlich <[email protected]>
christophfroehlich
added a commit
that referenced
this pull request
Jul 13, 2024
…bugging easier. (backport #1580) (#1582) * Small improvements to the error output in component parser to make debugging easier. (#1580) * Small improvements to the error output in component parser to make debugging easier. * Correct formatting. (cherry picked from commit fbb893b) # Conflicts: # hardware_interface/src/component_parser.cpp * Fix merge conflict --------- Co-authored-by: Dr. Denis <[email protected]> Co-authored-by: Christoph Froehlich <[email protected]> Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.