Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async Hardware Components #1567

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

saikishor
Copy link
Member

Needs : ros-controls/realtime_tools#168

This is to move towards the new async handling approach that we have done in a different PR also for the controllers.

@saikishor saikishor marked this pull request as ready for review June 17, 2024 17:18
Copy link
Contributor

mergify bot commented Jun 25, 2024

This pull request is in conflict. Could you fix it @saikishor?

@saikishor
Copy link
Member Author

Resolved conflicts!

Copy link
Contributor

mergify bot commented Jul 8, 2024

This pull request is in conflict. Could you fix it @saikishor?

@saikishor saikishor added this to the Pre-Jazzy (Feb.'24) milestone Jul 17, 2024
Copy link
Contributor

mergify bot commented Jul 21, 2024

This pull request is in conflict. Could you fix it @saikishor?

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 87.45%. Comparing base (a6e44ab) to head (f6a2d15).

Files with missing lines Patch % Lines
.../include/hardware_interface/actuator_interface.hpp 85.71% 3 Missing and 2 partials ⚠️
...ce/include/hardware_interface/system_interface.hpp 85.71% 3 Missing and 2 partials ⚠️
hardware_interface/src/resource_manager.cpp 66.66% 2 Missing ⚠️
hardware_interface/src/component_parser.cpp 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1567      +/-   ##
==========================================
+ Coverage   86.90%   87.45%   +0.55%     
==========================================
  Files         118      117       -1     
  Lines       11438    11547     +109     
  Branches     1051     1063      +12     
==========================================
+ Hits         9940    10099     +159     
+ Misses       1131     1084      -47     
+ Partials      367      364       -3     
Flag Coverage Δ
unittests 87.45% <93.33%> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/controller_manager.cpp 77.05% <ø> (+0.22%) ⬆️
...rface/include/hardware_interface/hardware_info.hpp 100.00% <ø> (ø)
...ce/include/hardware_interface/sensor_interface.hpp 96.77% <100.00%> (+3.02%) ⬆️
hardware_interface/src/actuator.cpp 74.82% <100.00%> (ø)
hardware_interface/src/sensor.cpp 72.26% <100.00%> (ø)
hardware_interface/src/system.cpp 74.82% <100.00%> (ø)
hardware_interface/test/test_component_parser.cpp 98.85% <100.00%> (+0.04%) ⬆️
...rface_testing/test/test_components/test_system.cpp 90.00% <100.00%> (+0.20%) ⬆️
...e_interface_testing/test/test_resource_manager.cpp 99.40% <100.00%> (+0.07%) ⬆️
hardware_interface/src/component_parser.cpp 94.34% <91.66%> (-0.09%) ⬇️
... and 3 more

... and 2 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Aug 26, 2024

This pull request is in conflict. Could you fix it @saikishor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant