Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move hardware interface README content to sphinx documentation (backport #1342) #1380

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 9, 2024

This is an automatic backport of pull request #1342 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@christophfroehlich
Copy link
Contributor

@mateusmenezes95 could you please check if this is feasible for humble, too?

@mateusmenezes95
Copy link
Contributor

@mateusmenezes95 could you please check if this is feasible for humble, too?

@christophfroehlich could you, please, give me hints on how to check this?

@christophfroehlich
Copy link
Contributor

@mateusmenezes95 could you please check if this is feasible for humble, too?

@christophfroehlich could you, please, give me hints on how to check this?

just a quick check if the code snippets make sense for humble (has the API of the used methods changed?)

@mateusmenezes95
Copy link
Contributor

@christophfroehlich I compared the snippets in the documentation with the example 1 of ros2_control_demos and there is no API change of the methods used in the examples. Hence, I think we can proceed with the merge in the humble branch.

@bmagyar bmagyar merged commit dbd806b into humble Feb 17, 2024
14 of 15 checks passed
@mergify mergify bot deleted the mergify/bp/humble/pr-1342 branch February 17, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants