Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] remove workflow dispatch branch #1362

Merged

Conversation

christophfroehlich
Copy link
Contributor

According to github docs (and linters), there is no field branches below workflow_dispatch. One can just select from a drop-down list on which branch the workflow should be started.

Copy link
Contributor

@moriarty moriarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SRTM

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5b5f332) 47.53% compared to head (bb85bea) 47.53%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1362   +/-   ##
=======================================
  Coverage   47.53%   47.53%           
=======================================
  Files          41       41           
  Lines        3549     3549           
  Branches     1931     1931           
=======================================
  Hits         1687     1687           
  Misses        459      459           
  Partials     1403     1403           
Flag Coverage Δ
unittests 47.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmagyar bmagyar merged commit b8c5418 into ros-controls:master Feb 7, 2024
16 of 17 checks passed
@christophfroehlich christophfroehlich deleted the ci_remove_workflow_dispatch branch February 7, 2024 22:52
@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Feb 7, 2024
mergify bot pushed a commit that referenced this pull request Feb 7, 2024
(cherry picked from commit b8c5418)

# Conflicts:
#	.github/workflows/foxy-binary-build-main.yml
#	.github/workflows/foxy-semi-binary-build-main.yml
#	.github/workflows/galactic-binary-build-main.yml
#	.github/workflows/galactic-semi-binary-build-main.yml
#	.github/workflows/iron-source-build.yml
mergify bot pushed a commit that referenced this pull request Feb 7, 2024
bmagyar pushed a commit that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants