review suggestions

ros-controls · Feb 1, 2024 · 6c27f4f · 6c27f4f
1 parent 9e69737
commit 6c27f4f
Show file tree

Hide file tree

Showing 8 changed files with 17 additions and 17 deletions.
diff --git a/hardware_interface/include/hardware_interface/actuator_interface.hpp b/hardware_interface/include/hardware_interface/actuator_interface.hpp
@@ -159,27 +159,27 @@ class ActuatorInterface : public rclcpp_lifecycle::node_interfaces::LifecycleNod
  // create error signal interface
  InterfaceInfo error_interface_info;
  error_interface_info.name = hardware_interface::ERROR_SIGNAL_INTERFACE_NAME;
- error_interface_info.data_type = "std::array<uint8_t>";
+ error_interface_info.data_type = "array<uint8_t>[32]";
  InterfaceDescription error_interface_descr(info_.name, error_interface_info);
  error_signal_ = std::make_shared<StateInterface>(error_interface_descr);
  // create error signal report message interface
  InterfaceInfo error_msg_interface_info;
  error_msg_interface_info.name = hardware_interface::ERROR_SIGNAL_MESSAGE_INTERFACE_NAME;
- error_msg_interface_info.data_type = "std::array<std::string>";
+ error_msg_interface_info.data_type = "array<string>[32]";
  InterfaceDescription error_msg_interface_descr(info_.name, error_msg_interface_info);
  error_signal_message_ = std::make_shared<StateInterface>(error_msg_interface_descr);
 
  // WARNING
  // create warning signal interface
  InterfaceInfo warning_interface_info;
  warning_interface_info.name = hardware_interface::WARNING_SIGNAL_INTERFACE_NAME;
- warning_interface_info.data_type = "std::array<uint8_t>";
+ warning_interface_info.data_type = "array<int8_t>[32]";
  InterfaceDescription warning_interface_descr(info_.name, warning_interface_info);
  warning_signal_ = std::make_shared<StateInterface>(warning_interface_descr);
  // create warning signal report message interface
  InterfaceInfo warning_msg_interface_info;
  warning_msg_interface_info.name = hardware_interface::WARNING_SIGNAL_MESSAGE_INTERFACE_NAME;
- warning_msg_interface_info.data_type = "std::array<std::string>";
+ warning_msg_interface_info.data_type = "array<string>[32]";
  InterfaceDescription warning_msg_interface_descr(info_.name, warning_msg_interface_info);
  warning_signal_message_ = std::make_shared<StateInterface>(warning_msg_interface_descr);
  }

diff --git a/hardware_interface/include/hardware_interface/sensor_interface.hpp b/hardware_interface/include/hardware_interface/sensor_interface.hpp
@@ -136,27 +136,27 @@ class SensorInterface : public rclcpp_lifecycle::node_interfaces::LifecycleNodeI
  // create error signal interface
  InterfaceInfo error_interface_info;
  error_interface_info.name = hardware_interface::ERROR_SIGNAL_INTERFACE_NAME;
- error_interface_info.data_type = "std::array<uint8_t>";
+ error_interface_info.data_type = "array<uint8_t>[32]";
  InterfaceDescription error_interface_descr(info_.name, error_interface_info);
  error_signal_ = std::make_shared<StateInterface>(error_interface_descr);
  // create error signal report message interface
  InterfaceInfo error_msg_interface_info;
  error_msg_interface_info.name = hardware_interface::ERROR_SIGNAL_MESSAGE_INTERFACE_NAME;
- error_msg_interface_info.data_type = "std::array<std::string>";
+ error_msg_interface_info.data_type = "array<string>[32]";
  InterfaceDescription error_msg_interface_descr(info_.name, error_msg_interface_info);
  error_signal_message_ = std::make_shared<StateInterface>(error_msg_interface_descr);
 
  // WARNING
  // create warning signal interface
  InterfaceInfo warning_interface_info;
  warning_interface_info.name = hardware_interface::WARNING_SIGNAL_INTERFACE_NAME;
- warning_interface_info.data_type = "std::array<uint8_t>";
+ warning_interface_info.data_type = "array<int8_t>[32]";
  InterfaceDescription warning_interface_descr(info_.name, warning_interface_info);
  warning_signal_ = std::make_shared<StateInterface>(warning_interface_descr);
  // create warning signal report message interface
  InterfaceInfo warning_msg_interface_info;
  warning_msg_interface_info.name = hardware_interface::WARNING_SIGNAL_MESSAGE_INTERFACE_NAME;
- warning_msg_interface_info.data_type = "std::array<std::string>";
+ warning_msg_interface_info.data_type = "array<string>[32]";
  InterfaceDescription warning_msg_interface_descr(info_.name, warning_msg_interface_info);
  warning_signal_message_ = std::make_shared<StateInterface>(warning_msg_interface_descr);
  }

diff --git a/hardware_interface/include/hardware_interface/system_interface.hpp b/hardware_interface/include/hardware_interface/system_interface.hpp
@@ -179,27 +179,27 @@ class SystemInterface : public rclcpp_lifecycle::node_interfaces::LifecycleNodeI
  // create error signal interface
  InterfaceInfo error_interface_info;
  error_interface_info.name = hardware_interface::ERROR_SIGNAL_INTERFACE_NAME;
- error_interface_info.data_type = "std::array<uint8_t>";
+ error_interface_info.data_type = "array<uint8_t>[32]";
  InterfaceDescription error_interface_descr(info_.name, error_interface_info);
  error_signal_ = std::make_shared<StateInterface>(error_interface_descr);
  // create error signal report message interface
  InterfaceInfo error_msg_interface_info;
  error_msg_interface_info.name = hardware_interface::ERROR_SIGNAL_MESSAGE_INTERFACE_NAME;
- error_msg_interface_info.data_type = "std::array<std::string>";
+ error_msg_interface_info.data_type = "array<string>[32]";
  InterfaceDescription error_msg_interface_descr(info_.name, error_msg_interface_info);
  error_signal_message_ = std::make_shared<StateInterface>(error_msg_interface_descr);
 
  // WARNING
  // create warning signal interface
  InterfaceInfo warning_interface_info;
  warning_interface_info.name = hardware_interface::WARNING_SIGNAL_INTERFACE_NAME;
- warning_interface_info.data_type = "std::array<uint8_t>";
+ warning_interface_info.data_type = "array<int8_t>[32]";
  InterfaceDescription warning_interface_descr(info_.name, warning_interface_info);
  warning_signal_ = std::make_shared<StateInterface>(warning_interface_descr);
  // create warning signal report message interface
  InterfaceInfo warning_msg_interface_info;
  warning_msg_interface_info.name = hardware_interface::WARNING_SIGNAL_MESSAGE_INTERFACE_NAME;
- warning_msg_interface_info.data_type = "std::array<std::string>";
+ warning_msg_interface_info.data_type = "array<string>[32]";
  InterfaceDescription warning_msg_interface_descr(info_.name, warning_msg_interface_info);
  warning_signal_message_ = std::make_shared<StateInterface>(warning_msg_interface_descr);
  }

diff --git a/...e_interface/include/hardware_interface/types/hardware_interface_emergency_stop_signal.hpp b/...e_interface/include/hardware_interface/types/hardware_interface_emergency_stop_signal.hpp
@@ -1,4 +1,4 @@
-// Copyright 2017 Open Source Robotics Foundation, Inc.
+// Copyright 2024 Stogl Robotics Consulting UG (haftungsbeschränkt)
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/hardware_interface/include/hardware_interface/types/hardware_interface_error_signals.hpp b/hardware_interface/include/hardware_interface/types/hardware_interface_error_signals.hpp
@@ -1,4 +1,4 @@
-// Copyright 2017 Open Source Robotics Foundation, Inc.
+// Copyright 2024 Stogl Robotics Consulting UG (haftungsbeschränkt)
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/hardware_interface/include/hardware_interface/types/hardware_interface_warning_signals.hpp b/hardware_interface/include/hardware_interface/types/hardware_interface_warning_signals.hpp
@@ -1,4 +1,4 @@
-// Copyright 2017 Open Source Robotics Foundation, Inc.
+// Copyright 2024 Stogl Robotics Consulting UG (haftungsbeschränkt)
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/hardware_interface/test/test_component_interfaces_custom_export.cpp b/hardware_interface/test/test_component_interfaces_custom_export.cpp
@@ -1,4 +1,4 @@
-// Copyright 2020 ros2_control development team
+// Copyright 2024 Stogl Robotics Consulting UG (haftungsbeschränkt)
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

diff --git a/hardware_interface/test/test_error_warning_codes.cpp b/hardware_interface/test/test_error_warning_codes.cpp
@@ -1,4 +1,4 @@
-// Copyright 2020 ros2_control development team
+// Copyright 2024 Stogl Robotics Consulting UG (haftungsbeschränkt)
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.