Fixes for non-ASCII name list fields in toBiblatex and toBibtex #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathew W. McLean <[email protected]>
* Always use pdfinfo to determine number of pages in each PDF in ReadPDFs even when use.metadata is FALSE * This avoids a message from pdftotext about incorrect pages * Refactor test-readPDF.R to make it clearer when tests are skipped if poppler is not installed Signed-off-by: Mathew W. McLean <[email protected]>
Signed-off-by: Mathew W. McLean <[email protected]>
* Add latexify() from dplR instead of tools::encoded_text_to_latex to improve conversion of non-ASCII characters to valid latex * Fixes #102, #105, #106 Signed-off-by: Mathew W. McLean <[email protected]>
Signed-off-by: Mathew W. McLean <[email protected]>
Signed-off-by: Mathew W. McLean <[email protected]>
* c.f. https://www.ncbi.nlm.nih.gov/books/NBK25499/table/chapter4.T._valid_values_of__retmode_and/ * Add mock response for one GetPubMedByID test Signed-off-by: Mathew W. McLean <[email protected]>
Signed-off-by: Mathew W. McLean <[email protected]>
* Attempt each GetPubMedByID test once with the entrez api, then use a cached/mock response if the request fails; add a failed test if all tests with API result in http errors Signed-off-by: Mathew W. McLean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add latexify() from dplR instead of tools::encoded_text_to_latex
to improve conversion of non-ASCII characters to valid latex
Use default value for rettype in ReadPubMed
Add mock response for one GetPubMedByID test"
Fixes RefManageR::ReadBib and RefManageR::WriteBib changes Ois{\'i}n to Ois{\a'\i}n #102, toBiblatex utf8 problems #105, toBiblatex can't handle CJK author names #106
c.f. Entrez docs, 400 error reports