Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gradle lint #1096

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Add gradle lint #1096

wants to merge 9 commits into from

Conversation

Tejas2805
Copy link
Contributor

We can add a gradle lint to check unused dependencies and deprecated packages and update them accordingly.

PR #1095 was based on this

@Tejas2805
Copy link
Contributor Author

@fzdy1914 @eugenepeh If you both think having a gradle lint is a good idea, I can try out more useful rules and apply them accordingly. Or I will just stick with PR #1095 Let me know your thoughts on it.

@eugenepeh
Copy link
Member

Hmm, if its a one-time thing then its better not to integrate it into the repo as it is also a plugin itself that may somewhat affect the build time. We can however, leave it as an active PR to help us detect misuse from time to time.

@github-actions github-actions bot requested a deployment to dashboard-1096 February 7, 2021 12:33 Abandoned
@github-actions github-actions bot requested a deployment to docs-1096 February 7, 2021 12:33 Abandoned
@fzdy1914
Copy link
Member

fzdy1914 commented Feb 7, 2021

@Tejas2805, I accidentally mess up this PR, can you help fix it?

@github-actions github-actions bot requested a deployment to dashboard-1096 February 22, 2021 13:01 Abandoned
@github-actions github-actions bot requested a deployment to docs-1096 February 22, 2021 13:01 Abandoned
@github-actions github-actions bot requested a deployment to dashboard-1096 January 22, 2022 12:23 Abandoned
@github-actions github-actions bot requested a deployment to docs-1096 January 22, 2022 12:23 Abandoned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants