-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Action for Closing Stale PRs #1299
Conversation
Tejas2805
commented
Jul 9, 2020
•
edited
Loading
edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we would have to create a GITHUB_TOKEN
secret so that u can use this workflow right
@eugenepeh might need you to add the access token as a secret |
I think that it will be required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
From the GitHub Action Docs
Hmm, doesn't seems like its needed to create this token. |
@Tejas2805 have u tried it in your repo? |
Yup have. This is the link |
Ok, you did not need to setup the GITHUB_TOKEN right? |
Oh, thought you were asking if it works. Yup, don't need to set GITHUB_TOKEN for actions related to PR, Issues, and more. Just checked documentation too. |
@fzdy1914 If all okay, can merge this? |
@Tejas2805 it seems to be failing |
Yep, seems to be failing. |
The PR has been reverted to prevent the failures and spam emails. The failure has the following log, @Tejas2805 can you investigate on it: |
@jamessspanggg @fzdy1914 I don't have access but can you guys check if this is enabled? If this is enabled, then need to switch to - Enable local and third-party Actions for this repository. |
@Tejas2805 So |
Is this enough? |
Actually when they say local they mean - actions for which the code is written within the repository or organization itself. |
Should be okay. |
Do we want the Actions to work on all PRs (current implementation) or PRs to the master branch only? |
Can we exempt for draft PRs like #1096? |
We can exempt them by adding a label to the PR. And exempt PRs with those labels from being closed. Does the label - s.DoNotMerge - work? |