fix: add statement to approve the installplan when a new operator is being installed #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CFSNM
force-pushed
the
installplan_approval
branch
from
e5b7965
to
666b913
Compare
CFSNM
requested review from
bdattoma,
jgarciao,
kobihk,
MarianMacik,
mattmahoneyrh,
jstourac and
asanzgom
asanzgom
previously approved these changes
Oct 24, 2024
Robot Results
|
CFSNM
force-pushed
the
installplan_approval
branch
from
666b913
to
2d9e1a1
Compare
CFSNM
force-pushed
the
installplan_approval
branch
from
2d9e1a1
to
0c6352c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bdattoma
reviewed
Oct 25, 2024
CFSNM
force-pushed
the
installplan_approval
branch
from
0c6352c
to
5ff2ef1
Compare
CFSNM
force-pushed
the
installplan_approval
branch
from
5ff2ef1
to
c83c74c
Compare
CFSNM
force-pushed
the
installplan_approval
branch
from
c83c74c
to
04a73b9
Compare
bdattoma
previously approved these changes
Oct 25, 2024
|
consider backporting the PR after the merge ✌️ |
|
@bdattoma yeah, once I merged that I plan to merge to the stable branches |
CFSNM
force-pushed
the
installplan_approval
branch
2 times, most recently
from
05f1cf1
to
b1f6b7f
Compare
|
@bdattoma can u please reapprove it? there was a typo in the IF clause that I had to fix |
CFSNM
force-pushed
the
installplan_approval
branch
from
b1f6b7f
to
d700418
Compare
CFSNM
force-pushed
the
installplan_approval
branch
2 times, most recently
from
7ad904f
to
bb19f4d
Compare
CFSNM
force-pushed
the
installplan_approval
branch
2 times, most recently
from
ef6ec36
to
0ae1f7a
Compare
CFSNM
force-pushed
the
installplan_approval
branch
from
0ae1f7a
to
535b216
Compare
CFSNM
force-pushed
the
installplan_approval
branch
2 times, most recently
from
714e76b
to
31d7956
Compare
CFSNM
force-pushed
the
installplan_approval
branch
from
c4ce0ab
to
3059f78
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related ticket: https://issues.redhat.com/browse/RHOAIENG-14362
Also enabling again the disruptive tests that were disabled in disconnected environments. This PR fixes that
Checks: