Skip to content

Commit

Permalink
fix: add statement to approve the installplan when a new operator is …
Browse files Browse the repository at this point in the history
…being installed
  • Loading branch information
CFSNM committed Oct 25, 2024
1 parent 1001504 commit 5ff2ef1
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
5 changes: 5 additions & 0 deletions ods_ci/tests/Resources/Page/Operators/ISVs.resource
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ Install ISV Operator From OperatorHub Via CLI # robocop: disable
${rc} ${out}= Run And Return Rc And Output sed -i'' -e "s/<CATALOG_SOURCE>/${catalog_source_name}/g" ${operator_sub_filepath} # robocop: disable
${rc} ${out}= Run And Return Rc And Output sed -i'' -e "s/<CS_NAMESPACE>/${cs_namespace}/g" ${operator_sub_filepath} # robocop: disable
Oc Apply kind=Subscription src=${operator_sub_filepath}
Sleep 60s reason=Waiting extra time to make sure the installplan is available
${return_code} ${installplans} Run And Return Rc And Output oc get installplans -n ${namespace} | grep -v NAME | awk '{print $1}'

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (142/120)

Check warning

Code scanning / Robocop

The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test

The assignment sign is not consistent within the file. Expected '=' but got '' instead
Should Be Equal As Integers ${return_code} 0 msg=Error while retrieving installplan
${return_code} ${out} Run And Return Rc And Output oc patch installplan ${installplans} -n ${namespace} --type='json' -p '[{"op": "replace", "path": "/spec/approved", "value": true}]' #robocop:disable

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (213/120)

Check warning

Code scanning / Robocop

The assignment sign is not consistent within the file. Expected '{{ expected_sign }}' but got '{{ actual_sign }}' instead Warning test

The assignment sign is not consistent within the file. Expected '=' but got '' instead

Check notice

Code scanning / Robocop

Variable '{{ name }}' is assigned but not used Note test

Variable '${out}' is assigned but not used
Should Be Equal As Integers ${return_code} 0 msg=Error while approving installplan


Create Operator Group
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ ${IS_NOT_PRESENT} 1
Validate DSC and DSCI Created With Errors When Service Mesh Operator Is Not Installed #robocop:disable
[Documentation] The purpose of this Test Case is to validate that DSC and DSCI are created
... without Service Mesh Operator installed, but with errors
[Tags] Operator Tier3 ODS-2584 RHOAIENG-2514 ExcludeOnDisconnected
[Tags] Operator Tier3 ODS-2584 RHOAIENG-2514
Remove DSC And DSCI Resources
Uninstall Service Mesh Operator CLI
Expand All @@ -50,7 +50,7 @@ Validate DSC and DSCI Created With Errors When Service Mesh Operator Is Not Inst
Validate DSC and DSCI Created With Errors When Serverless Operator Is Not Installed #robocop:disable
[Documentation] The purpose of this Test Case is to validate that DSC and DSCI are created
... without Serverless Operator installed, but with errors
[Tags] Operator Tier3 ODS-2586 RHOAIENG-2512 ExcludeOnDisconnected
[Tags] Operator Tier3 ODS-2586 RHOAIENG-2512
Remove DSC And DSCI Resources
Uninstall Serverless Operator CLI
Expand All @@ -70,7 +70,7 @@ Validate DSC and DSCI Created With Errors When Serverless Operator Is Not Instal
Validate DSC and DSCI Created With Errors When Service Mesh And Serverless Operators Are Not Installed #robocop:disable
[Documentation] The purpose of this Test Case is to validate that DSC and DSCI are created
... without dependant operators ((servicemesh, serverless) installed, but with errors
[Tags] Operator Tier3 ODS-2527 RHOAIENG-2518 ExcludeOnDisconnected
[Tags] Operator Tier3 ODS-2527 RHOAIENG-2518
Remove DSC And DSCI Resources
Uninstall Service Mesh Operator CLI
Expand All @@ -96,7 +96,7 @@ Validate DSC and DSCI Created With No Errors When Kserve Serving Is Unmanaged An
[Documentation] The purpose of this Test Case is to validate that DSC and DSCI are created
... without dependant operators ((servicemesh, serverless) installed and with no errors
... because the Kserve component serving is unmanaged
[Tags] Operator Tier3 RHOAIENG-3472 ExcludeOnDisconnected
[Tags] Operator Tier3 RHOAIENG-3472
Remove DSC And DSCI Resources
Uninstall Service Mesh Operator CLI
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ ${MSSG_REGEX} denied the request: only one service
*** Test Cases ***
Validate Service Mesh Control Plane Already Created
[Documentation] This Test Case validates that only one ServiceMeshControlPlane is allowed to be installed per project/namespace
[Tags] RHOAIENG-2517 ExcludeOnDisconnected
[Tags] RHOAIENG-2517
Fetch Image Url And Update Channel
Check Whether DSC Exists And Save Component Statuses
Fetch Cluster Type By Domain
Expand Down

0 comments on commit 5ff2ef1

Please sign in to comment.