Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto assign PR to author #16969
base: branch-24.12
Are you sure you want to change the base?
Auto assign PR to author #16969
Changes from all commits
d7ad8e4
d1ce191
8b7dffc
43a0407
7f6246b
13e8b90
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe on reopen too? Anything else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
edited
too? If a second person starts pushing to the PR then we can make them both share ownership. The one caveat is that it might get messy with people merging upstream, but if there isn't an easy way to avoid that I think adding them is better than not. WDYT @Matt711 and @bdice?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the documentation,
edited
meanswhereas
synchronize
meansSo we might want
synchronize
overedited
.Since the commit message is always something like
Merge {latest branch} into {current branch}
, we might be able to not run the job when we get this message (I'm not sure how to do this though.)