Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto assign PR to author #16969

Open
wants to merge 6 commits into
base: branch-24.12
Choose a base branch
from

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Oct 1, 2024

Description

I think most PRs remain unassigned, so this PR auto assigns the PR to the PR author. I think this will help keep our project boards up-to-date.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 added non-breaking Non-breaking change ci improvement Improvement / enhancement to an existing function labels Oct 1, 2024
Copy link
Contributor Author

@Matt711 Matt711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm requesting a review because I have a couple questions.

.github/workflows/auto-assign.yml Show resolved Hide resolved
on:
pull_request_target:
types:
- opened
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe on reopen too? Anything else?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe edited too? If a second person starts pushing to the PR then we can make them both share ownership. The one caveat is that it might get messy with people merging upstream, but if there isn't an easy way to avoid that I think adding them is better than not. WDYT @Matt711 and @bdice?

Copy link
Contributor Author

@Matt711 Matt711 Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe edited too? If a second person starts pushing to the PR then we can make them both share ownership.

From the documentation, edited means

The title or body of a pull request was edited, or the base branch of a pull request was changed.

whereas synchronize means

A pull request's head branch was updated. For example, the head branch was updated from the base branch or new commits were pushed to the head branch.

So we might want synchronize over edited.

The one caveat is that it might get messy with people merging upstream, but if there isn't an easy way to avoid that I think adding them is better than not.

Since the commit message is always something like Merge {latest branch} into {current branch}, we might be able to not run the job when we get this message (I'm not sure how to do this though.)

@Matt711 Matt711 marked this pull request as ready for review October 3, 2024 17:58
@Matt711 Matt711 requested a review from a team as a code owner October 3, 2024 17:58
@Matt711 Matt711 requested a review from bdice October 3, 2024 17:58
@Matt711 Matt711 added the 3 - Ready for Review Ready for review by team label Oct 8, 2024
@bdice
Copy link
Contributor

bdice commented Oct 16, 2024

@vyasr You were interested in increasing automation. What do you think of this proposal?

Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is a (small) positive change overall. I don't think it's crucial since PR ownership is something that we often handle implicitly and it's much more important for issues where it isn't always obvious who is working on it unless there is a linked PR, but I think this is lightweight enough to be worth adding. Apologies for the slow response.

on:
pull_request_target:
types:
- opened
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe edited too? If a second person starts pushing to the PR then we can make them both share ownership. The one caveat is that it might get messy with people merging upstream, but if there isn't an easy way to avoid that I think adding them is better than not. WDYT @Matt711 and @bdice?

.github/workflows/auto-assign.yml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants