Allow updated_at to be an epoch string #165
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multun
force-pushed
the
updated-at-string
branch
from
c107ff5
to
375812e
Compare
Allow unix timestamps within a string for updated_at, as follows: "updated_at": "1713964430.299453" This is not allowed by the specification, but was observed in the wild on at least one OpenAM instance. This misbehavior is probably caused by a plugin. This parsing leniancy feature is gated behind "accept-string-epoch".
multun
force-pushed
the
updated-at-string
branch
from
375812e
to
964d84b
Compare
multun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow unix timestamps within a string for updated_at, as follows:
"updated_at": "1713964430.299453"This is not allowed by the specification, but was observed in the wild on at least one OpenAM
instance. This misbehavior is probably caused by a plugin or unusual config, as other OpenAM
instances work just fine.
Instance owners were notified, and aren't willing to do anything about it.
This parsing leniancy feature is gated behind "accept-string-epoch".