Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway: use a fork of openidconnect-rs with leniant update_at parsing #7310

Merged
merged 1 commit into from
May 14, 2024

Conversation

multun
Copy link
Contributor

@multun multun commented Apr 25, 2024

  • update openidconnect-rs to the release candidate, which is the base for this patch
  • update reqwest to its latest version, which is pull in anyway by the new version of openidconnect-rs

@multun multun requested a review from a team as a code owner April 25, 2024 09:53
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 29.11%. Comparing base (6079b64) to head (94828c1).

❗ Current head 94828c1 differs from pull request most recent head 290bc0f. Consider uploading reports for the commit 290bc0f to get more accurate results

Files Patch % Lines
gateway/actix_auth/src/providers/oidc.rs 0.00% 28 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #7310       +/-   ##
=============================================
+ Coverage     18.79%   29.11%   +10.32%     
- Complexity     2016     2020        +4     
=============================================
  Files           903     1138      +235     
  Lines        114916   139748    +24832     
  Branches       2809     2757       -52     
=============================================
+ Hits          21594    40686    +19092     
- Misses        91668    97453     +5785     
+ Partials       1654     1609       -45     
Flag Coverage Δ
core 76.76% <ø> (+0.47%) ⬆️
editoast 72.04% <ø> (?)
front 9.34% <ø> (-0.50%) ⬇️
gateway 2.41% <0.00%> (-0.03%) ⬇️
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gateway/Cargo.toml Show resolved Hide resolved
@multun multun enabled auto-merge May 14, 2024 08:12
@multun multun disabled auto-merge May 14, 2024 08:13
@multun multun merged commit 56e7358 into dev May 14, 2024
9 checks passed
@multun multun deleted the workaround-broken-oidc branch May 14, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants