Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify odbcDataType.Snowflake to better reflect Snowflake Data Type… #599

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Modify odbcDataType.Snowflake to better reflect Snowflake Data Type… #599

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48dd01b
Modify `odbcDataType.Snowflake` to better reflect Snowflake Data Type…
meztez Aug 31, 2023
c8a3110
Merge branch 'main' into master
detule Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# odbc (development version)

* Modify `odbcDataType.Snowflake` to better reflect Snowflake Data Types documentation (@meztez, #599).

# odbc 1.3.5

* Various fixes for `R CMD check`.
Expand Down
10 changes: 5 additions & 5 deletions R/DataTypes.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,16 +300,16 @@ odbcDataType.Oracle <- function(con, obj, ...) {
`odbcDataType.Snowflake` <- function(con, obj, ...) {
switch_type(
obj,
factor = "VARCHAR(255)",
factor = "VARCHAR",
datetime = "TIMESTAMP",
date = "DATE",
time = "TIME",
binary = "VARBINARY(255)",
binary = "BINARY",
integer = "INTEGER",
double = "DOUBLE PRECISION",
character = "VARCHAR(255)",
double = "FLOAT",
character = "VARCHAR",
logical = "BOOLEAN",
list = "VARCHAR(255)",
list = "VARCHAR",
stop("Unsupported type", call. = FALSE)
)
}
Expand Down
Loading