Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify odbcDataType.Snowflake to better reflect Snowflake Data Type… #599

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

meztez
Copy link
Contributor

@meztez meztez commented Aug 31, 2023

…s documentation

https://docs.snowflake.com/en/sql-reference/data-types

When choosing the maximum length for a VARCHAR column, consider the following:

  • Storage: A column consumes storage for only the amount of actual data stored. For example, a 1-character string in a VARCHAR(16777216) column only consumes a single character.

  • Performance: There is no performance difference between using the full-length VARCHAR declaration VARCHAR(16777216) and a smaller length.

Since it is used to create tables in Snowflake, I do no see why (from above) it should be limited to 255.

Limiting it can introduce truncation bugs on the user end.

I am a firm believer in preventing end user potential bugs.

@detule detule merged commit 39a42f6 into r-dbi:main Sep 27, 2023
19 checks passed
@detule
Copy link
Collaborator

detule commented Sep 27, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants