Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: x-axis data missing in alpha rarefaction viz #360

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

lizgehret
Copy link
Member

fixes #359

So this does work, but I'm not happy with the fact that this had to be added (seemingly) randomly. I'm signing off for the day, but will try to find a better solution that addresses what changed from 2024.2 to 2024.5 tomorrow.

@Oddant1
Copy link
Member

Oddant1 commented Jun 12, 2024

@lizgehret the image in this viz is in svg, so each element of the viz has actual DOM nodes. That means in theory we can test it with selenium. If we are patching, we shouldn't hold up the patch for that, but it's probably worth adding those tests. If only they had been added ages ago lol.

@lizgehret
Copy link
Member Author

@lizgehret the image in this viz is in svg, so each element of the viz has actual DOM nodes. That means in theory we can test it with selenium. If we are patching, we shouldn't hold up the patch for that, but it's probably worth adding those tests. If only they had been added ages ago lol.

I agree on both counts - we should add tests, but we should wait until after the patch to do so. Want to walk me through selenium testing next week when I'm back in office?

@Oddant1
Copy link
Member

Oddant1 commented Jun 12, 2024

Sure

@lizgehret lizgehret self-assigned this Jun 20, 2024
@ebolyen ebolyen self-assigned this Jun 20, 2024
@lizgehret
Copy link
Member Author

lizgehret commented Jun 20, 2024

update 1: viz works as expected without metadata as input.

update 2: this is the culprit. the updated fix ensures that these names match the multi-index DF, so that the names aren't overwritten in the case that they don't match up when the merge occurs.

@lizgehret lizgehret merged commit 368a9eb into dev Jun 20, 2024
4 checks passed
@lizgehret lizgehret deleted the alpha-rarefaction-testing branch June 20, 2024 20:55
@lizgehret lizgehret removed their assignment Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

BUG: alpha_rarefaction viz has lost sequencing depth data
3 participants