Update QAT: add grad clipping, torch.compile, collate fn #1854
+236
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1854
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3df9045 with merge base f560cbb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
andrewor14
force-pushed
the
update-qat
branch
from
5a2aa35
to
5aef800
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1854 +/- ##
==========================================
+ Coverage 67.30% 69.19% +1.89%
==========================================
Files 304 305 +1
Lines 16000 16031 +31
==========================================
+ Hits 10768 11092 +324
+ Misses 5232 4939 -293 ☔ View full report in Codecov by Sentry. |
andrewor14
force-pushed
the
update-qat
branch
from
5aef800
to
8b55ce7
Compare
joecummings
reviewed
Oct 21, 2024
andrewor14
force-pushed
the
update-qat
branch
from
8b55ce7
to
bb0cc85
Compare
**Summary:** Update the qat_distributed recipe to match the full_finetune_distributed recipe. This commit adds features to QAT like gradient clipping, torch.compile, and user configurable collate function for data pre-processing. **Test Plan:** TBD
andrewor14
force-pushed
the
update-qat
branch
from
bb0cc85
to
3df9045
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Update the qat_distributed recipe to match the full_finetune_distributed recipe. This commit adds features to QAT like gradient clipping, torch.compile, and user configurable collate function for data pre-processing.
Test Plan: TBD