Rewrite github tests #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aseyboldt
force-pushed
the
fix-build
branch
4 times, most recently
from
1f7b19f
to
1d01448
Compare
maresb
reviewed
Apr 25, 2024
.github/workflows/main.yml
Outdated
| run: | | ||
| conda mambabuild --variants "{python: [${{ matrix.python-version }}]}" ./sunode/conda | ||
| - name: Install package | ||
| env |
There was a problem hiding this comment.
I'd be concerned about potential secret leakage here. Would it make sense to narrow this to the particular variables that are useful?
Otherwise everything looks in excellent shape!
There was a problem hiding this comment.
Good point, I removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the tests were building a conda package, instead we should just install it using pip