Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Narrow return type for ContentStream.operations #2941

Merged
merged 1 commit into from
Nov 13, 2024
Merged

MAINT: Narrow return type for ContentStream.operations #2941

merged 1 commit into from
Nov 13, 2024

Conversation

kmurphy4
Copy link
Contributor

@kmurphy4 kmurphy4 marked this pull request as ready for review November 13, 2024 15:43
@kmurphy4 kmurphy4 mentioned this pull request Nov 13, 2024
Merged
@kmurphy4
Copy link
Contributor Author

btw, I wasn't sure if "ROB" was the correct prefix, so happy to change that if you'd like 😅

@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (7678eff) to head (8db764f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2941   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files          52       52           
  Lines        8749     8749           
  Branches     1591     1591           
=======================================
  Hits         8435     8435           
  Misses        186      186           
  Partials      128      128

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefan6419846
Copy link
Collaborator

I am not completely sure about the prefix, but probably tend to prefer MAINT or STY.

@kmurphy4 kmurphy4 force-pushed the narrow-content-stream-operations-return-type branch from e52219f to 8db764f Compare November 13, 2024 17:38
@kmurphy4
Copy link
Contributor Author

I am not completely sure about the prefix, but probably tend to prefer MAINT or STY.

fixed!

@stefan6419846 stefan6419846 changed the title ROB: Narrow return type for ContentStream.operations MAINT: Narrow return type for ContentStream.operations Nov 13, 2024
stefan6419846
stefan6419846 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@stefan6419846 stefan6419846 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@stefan6419846 stefan6419846 merged commit 66089ac into py-pdf:main Nov 13, 2024
17 checks passed
@kmurphy4 kmurphy4 deleted the narrow-content-stream-operations-return-type branch November 13, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefan6419846 stefan6419846 stefan6419846 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmurphy4 @stefan6419846