-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Remove b_ and str_ #2792
Conversation
closes py-pdf#2726 superseed proposal py-pdf#2791
Could you please provide some further rationale for this change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2792 +/- ##
==========================================
+ Coverage 95.16% 95.26% +0.09%
==========================================
Files 51 51
Lines 8545 8535 -10
Branches 1703 1700 -3
==========================================
- Hits 8132 8131 -1
+ Misses 261 252 -9
Partials 152 152 ☔ View full report in Codecov by Sentry. |
after analysis, most of the b_ were required due to StreamObjects. I've fixed the cases where a string was generated instead of bytes. some operators from operations were inserted as text instead of string.I've also refactored some functions to try to improve performances. there is still a little of work for coverage (under analysis) but @stefan6419846 / @j-t-1 waiting for your comments |
This is a win. These kinds of improvements make pypdf more readable, understandable and extensible. |
test coverage is good now. |
closes #2726
superseed proposal #2791