Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Hyperbus peripheral #47

Open
wants to merge 5 commits into
base: devel
Choose a base branch
from
Open

Integrate Hyperbus peripheral #47

wants to merge 5 commits into from

Conversation

sermazz
Copy link

@sermazz sermazz commented Oct 4, 2024

This PR:

@sermazz sermazz changed the base branch from main to devel October 4, 2024 18:17
@sermazz sermazz force-pushed the smazzola/hyperbus branch 5 times, most recently from 19cbd63 to d1090d3 Compare October 7, 2024 12:02
Copy link

@Lore0599 Lore0599 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

hw/chimera_top_wrapper.sv Outdated Show resolved Hide resolved
sw/tests/testHyperbusAddr.c Outdated Show resolved Hide resolved
hw/chimera_pkg.sv Show resolved Hide resolved
hw/chimera_pkg.sv Outdated Show resolved Hide resolved
@sermazz sermazz changed the title Integrate Hyperbus peripheral and test infrastructure Integrate Hyperbus integration + stack pointer fix Oct 8, 2024
@sermazz sermazz changed the title Integrate Hyperbus integration + stack pointer fix Integrate Hyperbus peripheral Oct 8, 2024
@sermazz
Copy link
Author

sermazz commented Oct 17, 2024

@Lore0599 @arpansur @Scheremo @adimauro-iis
CI is finally passing after the fixes on devel, we should now define the range we need for HyperRAM (https://github.com/pulp-platform/chimera/pull/47/files#diff-7310782802ac0d64363e8ceb9e90e54a5c0c858fc1e63688d48ad6964dd3fb4bR131). And also have a plan for #43.
If these are not blocking, we can merge.

@Scheremo
Copy link
Collaborator

@Lore0599 @arpansur @Scheremo @adimauro-iis CI is finally passing after the fixes on devel, we should now define the range we need for HyperRAM (https://github.com/pulp-platform/chimera/pull/47/files#diff-7310782802ac0d64363e8ceb9e90e54a5c0c858fc1e63688d48ad6964dd3fb4bR131). And also have a plan for #43. If these are not blocking, we can merge.

I think both are blocking but trivial to resolve. You can extend the register memory map range (0x3000_0000 - 0x4000_0000) contiguously with the config registers and map the hyperbus memory "somewhere reasonable" (why not 0x5000_0000?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants