Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify check for symlinks that resolve outside root #4221

Merged
merged 3 commits into from
Feb 11, 2024
Merged

Simplify check for symlinks that resolve outside root #4221

merged 3 commits into from
Feb 11, 2024

Commits on Feb 11, 2024

  1. Simplify check for symlinks that resolve outside root 

    This PR does not change any behaviour.

There have been 1-2 issues about symlinks recently. Both over and under
resolving can cause problems. This makes a case where we resolve more
explicit and prevent a resolved path from leaking out via the return.
    @hauntsaninja
    hauntsaninja committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    289ad77 View commit details
    Browse the repository at this point in the history

  2. catch os.getcwd

    @hauntsaninja
    hauntsaninja committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    d1e5683 View commit details
    Browse the repository at this point in the history

  3. Update tests/test_black.py

    @JelleZijlstra
    JelleZijlstra authored Feb 11, 2024
    Configuration menu
    Copy the full SHA
    800afb3 View commit details
    Browse the repository at this point in the history