Simplify check for symlinks that resolve outside root #4221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR does not change any behaviour. There have been 1-2 issues about symlinks recently. Both over and under resolving can cause problems. This makes a case where we resolve more explicit and prevent a resolved path from leaking out via the return.
hauntsaninja
added
the
skip news
hauntsaninja
changed the title
hauntsaninja
force-pushed
the
normalise-simplify
branch
from
08192e7
to
289ad77
Compare
hauntsaninja
commented
Feb 11, 2024
| @@ -780,7 +777,7 @@ def get_sources( | |||
| continue | |||
|
|
|||
| if verbose: | |||
| out(f'Found input source: "{normalized_path}"', fg="blue") | |||
There was a problem hiding this comment.
We don't use the value of normalized_path, we do sources.add(path), so no point logging it
hauntsaninja
force-pushed
the
normalise-simplify
branch
from
c1b00ef
to
d1e5683
Compare
JelleZijlstra
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not change any behaviour.
This would have made the #4015 / #4161 bug much more obvious. This makes a case where we resolve more explicit and prevent a resolved path from leaking out via the return.