-
-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not display options for Site Administrator to create, modify, or delete Manager users #5244
Conversation
✅ Deploy Preview for volto ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@wesleybl are you aware that we have a GSOC that is taking care of improving the User Control Panel? |
@sneridagh maybe this PR isn't the same thing @robgietema is doing. This needs modifications to I am making the changes requested in @davisagli ' review. After these modifications, I will need to modify this PR here as well. Anyway, I would like to know what @robgietema is doing. |
fde4259
to
dec7146
Compare
✅ Deploy Preview for plone-components canceled.
|
09a6247
to
628a252
Compare
delete Manager users
@sneridagh @davisagli @ksuess as suggested by @davisagli and @ksuess in plone/plone.restapi#1712, I removed the can delete and can assign information from the endpoints and adapted this PR to search for the althenticated user roles and make the necessary blocks in interface. Can you take a look please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
I tested. Also with many_users/many_groups.
LGTM
Maybe a test for a non-manager?
|
@ksuess I added the test. Thanks for your review! |
Would you add also a test for a non-manager user for groups in RenderGroups.test.js? I'll add tests for user group membership control panel. #5786 later. |
Done |
Dear maintainers, please have a look. |
* @method canAssingGroup | ||
* @returns {boolean} | ||
*/ | ||
export function canAssingGroup(isManager, group) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is misspelled:
export function canAssingGroup(isManager, group) { | |
export function canAssignGroup(isManager, group) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix.
@sneridagh can we merge this PR? |
* main: (299 commits) Release 18.0.0-alpha.20 Add BBB code for removed WysiwygWidget (#5874) Release 18.0.0-alpha.19 Release @plone/components 2.0.0-alpha.7 Release @plone/slate 18.0.0-alpha.10 Release generate-volto 9.0.0-alpha.11 Release @plone/types 1.0.0-alpha.6 Improve deps in project generator (#5872) Fix broken link to TanStack Query (#5871) Add missing nextjs install step (#5857) (Fix): Sorting Order and Sorting On are not working in Search Block edit mode (#5262) Update docs for defaultBlockType setting (#5862) Add reference to Docker installation for some Linux distributions (#5861) Fix further internal `blocksConfig` pass by reference present in core (related to #5850) (#5859) The proper name is Semantic UI (#5855) Update link to cssnano docs (#5853) [components] Container css (#5849) Do not display options for Site Administrator to create, modify, or delete Manager users (#5244) Fix the introduction of a mutable (referenced) object when assigning … (#5850) Remove draftJS (and related legacy blocks `text`, `table` and `hero`) from core and cleanup dependencies (#5846) ...
Ref: plone/plone.restapi#1712
Ref: #3917