Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests groupmembership panel #5801

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Tests groupmembership panel #5801

wants to merge 10 commits into from

Conversation

ksuess
Copy link
Member

@ksuess ksuess commented Feb 26, 2024

Needs plone.restapi>=9.3.0 (# 1712 Give Site Administrator permission to manage users)

ON HOLD until DOCKER_IMAGE_ACCEPTANCE includes plone.restapi>=9.3.0

DOCKER_IMAGE_ACCEPTANCE=plone/server-acceptance:6.0.9

Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for volto ready!

Name Link
🔨 Latest commit c88aea0
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/65dc6b893f139c0008ac907a
😎 Deploy Preview https://deploy-preview-5801--volto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ksuess ksuess changed the base branch from main to site_administrator February 26, 2024 10:44
Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for plone-components ready!

Name Link
🔨 Latest commit c88aea0
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/65dc6b897dd45d0008cb4333
😎 Deploy Preview https://deploy-preview-5801--plone-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ksuess
Copy link
Member Author

ksuess commented Feb 26, 2024

Need some help with cy.autologin for non-manager users.

describe('User Group Membership Control Panel test for non-manager', () => {
  beforeEach(() => {
    init();
    cy.createUser({
      username: 'siteadmin',
      fullname: 'Sven Siteadministrator',
      roles: ['Site Administrator'],
    });
    cy.autologin('siteadmin', 'password');
  });

Now with role Site Administrator the user should be granted the right to use the group membership panel, which is at least fetching Plone restapi @users and @groups.

@wesleybl
Copy link
Member

@ksuess there is still a problem with Site Adminstrator add users to groups. To see:

plone/plone.restapi#1751

There has not yet been a release of plone.restapi with this fix.

@ksuess
Copy link
Member Author

ksuess commented Feb 26, 2024

@tisto Can we get a release of plone.restapi, please, to proceed with #5244.

@tisto
Copy link
Member

tisto commented Feb 27, 2024

@ksuess I released plone.restapi 9.5.0.

@davisagli
Copy link
Member

@ksuess plone.restapi 9.5.0 is included in Plone 6.0.10.1 which has Docker images available today. :)

Base automatically changed from site_administrator to main March 6, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test for user and especially non-manager user in UserGroupMembershipControlPanel.test.jsx
4 participants