Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platformify Django projects #26

Merged
merged 11 commits into from
Mar 28, 2023
Merged

Platformify Django projects #26

merged 11 commits into from
Mar 28, 2023

Conversation

akalipetis
Copy link
Member

This introduces a full Platformification logic for Django projects.

The code is a lot, so it might be better to look into specific commits in some cases.

High-level changes:

  • Add Django-related templates
  • Simplify for-loop questions so that the question can be skipped with an empty name
  • Automatically discover the environment, build, deploy, and web commands for Django projects

@akalipetis
Copy link
Member Author

@zendoodles @vintorez feel free to take a look!

Copy link
Collaborator

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note; survey is a lovely package with lovely results. The last time I used it it wasn't functional under Windows git-bash, if that's a targeted environment:

Also note that the import is wrong, the project has moved to https://github.com/go-survey/survey

@akalipetis
Copy link
Member Author

Thanks @rfay - opened #28 to handle that before GA 💪🏽

@akalipetis akalipetis force-pushed the akalipetis/issue-4 branch 2 times, most recently from 78b8440 to 9894dde Compare March 24, 2023 13:15
@vintorez
Copy link
Contributor

Also note that the import is wrong, the project has moved to https://github.com/go-survey/survey

@rfay the import is correct because we import projects by their module names (not by project names). The project has moved to https://github.com/go-survey/survey, but the module name remained the same (source)

@rfay
Copy link
Collaborator

rfay commented Mar 25, 2023

That's pretty amazing. I see the issue about this:

@akalipetis akalipetis merged commit a14c1cd into main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants