Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not install dependencies in build if lock file does not exist #31

Closed
akalipetis opened this issue Mar 24, 2023 · 4 comments
Closed

Comments

@akalipetis
Copy link
Member

We need to verify that the respective lock file exists (poetry.lock, pipenv.lock, requirements.txt, yarn.lock, etc), before adding the dependency installation command in the build steps.

          What if no `requirements.txt` is present?

Originally posted by @lolautruche in #26 (comment)

@lolautruche
Copy link
Contributor

I'm not sure about actual lock files. My original comment aimed at the potential lack of requirements.txt file (equivalent to Pipfile or pyproject.toml)

@akalipetis
Copy link
Member Author

We might end up in the exact same situation if the user selects Poetry, but there are no pyproject.toml and poetry.lock files in their repository, that's why I generalized it like that.

Same for package.json, yarn.lock, etc...

@vintorez
Copy link
Contributor

What actions should we take if the user selects "pip" and we can't find the "requirements.txt"?
Should we keep the build steps empty?
Or perhaps, should we provide somewhere pip install -r requirements.txt as a suggestion/hint to the user?

@akalipetis
Copy link
Member Author

This should be handled by #57 - we should remove the question altogether and automatically pick the correct dependency manager.

@akalipetis akalipetis closed this as not planned Won't fix, can't repro, duplicate, stale Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants