*: support gbk charset #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
PTAL @morgo @tangenta @xiongjiwei |
xiongjiwei
reviewed
Nov 19, 2021
| @@ -155,7 +167,7 @@ func isTiDB(db *sql.DB) bool { | |||
| } | |||
|
|
|||
| func (t *tester) addConnection(connName, hostName, userName, password, db string) { | |||
| mdb, err := OpenDBWithRetry("mysql", userName+":"+password+"@tcp("+hostName+":"+port+")/"+db+"?strict=true&time_zone=%27Asia%2FShanghai%27"+params) | |||
| mdb, err := OpenDBWithRetry("mysql", userName+":"+password+"@tcp("+hostName+":"+port+")/"+db+"?time_zone=%27Asia%2FShanghai%27"+params) | |||
There was a problem hiding this comment.
what is the strict mean, why we need remove it
There was a problem hiding this comment.
The strict mode is an option in the driver that changes warnings to errors. However in newer versions of the driver this has been removed.
Merged
xiongjiwei
previously approved these changes
Nov 19, 2021
bb7133
reviewed
Nov 19, 2021
src/main.go
Outdated
| @@ -800,6 +796,7 @@ func (t *tester) executeStmt(query string) error { | |||
| return errors.Trace(err) | |||
| } | |||
| } | |||
|
|
|||
dveeden
approved these changes
Nov 19, 2021
zimulala
commented
Nov 22, 2021
| if strings.EqualFold(coll.CharsetName, c.Name) { | ||
| charset.AddCollation(coll) | ||
| } | ||
| } |
There was a problem hiding this comment.
GBK related issues are dealt with here. @dveeden
bb7133
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add gbk charset, close: Allow this framework to run GBK related tests #31
close dependency on github.com/go-sql-driver/mysql v1.3.0 is old #25.
MySQLWarningsis removed in go-sql-driver/mysql(v1.6.0). So here remove it too.strict modeis removed too in Remove strict mode go-sql-driver/mysql#676.