Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #37

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Update dependencies #37

merged 1 commit into from
Nov 23, 2021

Conversation

dveeden
Copy link
Collaborator

@dveeden dveeden commented Nov 19, 2021

The biggest change is that the MySQL driver removed strict-mode which changes how warnings are handled.

Closes #25

@dveeden
Copy link
Collaborator Author

dveeden commented Nov 19, 2021

/cc @morgo

@dveeden
Copy link
Collaborator Author

dveeden commented Nov 19, 2021

This is making similar changes as #33 except for the actual GBK part

@zimulala
Copy link
Collaborator

It seems this PR and #33 content is repeated.

@dveeden
Copy link
Collaborator Author

dveeden commented Nov 22, 2021

Not closing this as planned, even while #33 has been merged.

This updates a few more deps (from go get -u ./...) and fixes the regression from #33:

[dvaneeden@dve-carbon mysql-tester]$ git rev-parse HEAD
33200960bc1486259caceae3ceb08b346c39e9f6
[dvaneeden@dve-carbon mysql-tester]$ make build
go build -o mysql-tester ./src
# github.com/pingcap/mysql-tester/src
src/main.go:148:26: undefined: mysql
make: *** [Makefile:6: build] Error 2
[dvaneeden@dve-carbon mysql-tester]$ git checkout update_deps 
Switched to branch 'update_deps'
Your branch is up to date with 'origin/update_deps'.
[dvaneeden@dve-carbon mysql-tester]$ git rev-parse HEAD
0ee1edf56e749a58fe3399e8b884751c7b36bf3d
[dvaneeden@dve-carbon mysql-tester]$ make build
go build -o mysql-tester ./src
[dvaneeden@dve-carbon mysql-tester]$

/cc @zimulala @bb7133 @morgo

@morgo
Copy link
Contributor

morgo commented Nov 22, 2021

LGTM

(I don't think I have review privileges in this repo.)

Copy link
Collaborator

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@hawkingrei hawkingrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 merged commit 9099f3c into pingcap:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dependency on github.com/go-sql-driver/mysql v1.3.0 is old
5 participants