chore: update controller tools from v0.11.0 to v0.14.0 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basti1302
force-pushed
the
update-controller-tools-version
branch
from
9572263
to
4391824
Compare
Nexucis
reviewed
Oct 8, 2024
This should fix the build error that currently happens: panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xa[40] Signed-off-by: Bastian Krol <[email protected]>
basti1302
force-pushed
the
update-controller-tools-version
branch
from
4391824
to
2c9525b
Compare
Nexucis
approved these changes
Oct 9, 2024
|
for the linter issue, I think it's more related to golanglint-ci itself. WIll merge and adress the issue when I can |
|
Thanks for merging.
Right. I think the linting fails because it is executed with Go 1.23, and it might work with an older Go version (1.22 or 1.21). I had similar issues in another project of mine as well; it seems golanglint-ci is picky about the Go version it is executed with. But I am not sure where the Go version for the linting step is set, it seems to come from either |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the build error that currently happens: panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xa[40]