-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix outdated sample resources, add crd installation to readme #13
Conversation
kind: Dashboard | ||
metadata: | ||
name: Demo-2 | ||
project: default | ||
createdAt: "2021-11-09T00:00:00Z" | ||
updatedAt: "2021-11-09T00:00:00Z" | ||
version: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this has not been updated after 3a8e219. Now the resource is valid again. Same for the other dashboard resource.
faf738d
to
87ce3d2
Compare
Hey @basti1302 thank you for opening this PR ! Sorry for the long time to reply. We put this repository on pause for the moment because we are on other subjects that have a higher priority. So this operator is still working in progress and will stay like that until an unknown date. So we are definitely looking for contribution to finish this operator ! I am just saying that in case you would like to do it :). In the meantime @jgbernalp if you have some time to look at the PR, would be cool :). Also @basti1302 I have ran the CI and it looks like there are some issues. Can you check it ? Thanks |
Thanks for the update with regard to the state of this repository. Unfortunately I do not have the capacity to contribute significantly to this project. The CI build issues are unrelated to this PR.
IIRC this is a known bug either in the operator framework or some related dependency. Could be this one, not sure: operator-framework/operator-sdk#6230 Locally I bumped CONTROLLER_TOOLS_VERSION I can create a separate PR, however, that will also regenerate things in |
no worries it was just in case Thanks for checking @basti1302 |
I created a PR for updating the controller tools version here: #14 |
LGTM, we can merge when the pipeline is fixed with #14 |
PR #14 has been merged. @basti1302 Can you rebase your PR to see if the build is passing ? Thanks for your work here, that is super appreciated ! |
fixes perses#12 Signed-off-by: Bastian Krol <[email protected]>
87ce3d2
to
7db457c
Compare
Rebased, you're welcome 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome !
fixes #12