Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix outdated sample resources, add crd installation to readme #13

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

basti1302
Copy link
Contributor

fixes #12

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
config/samples/kustomization.yaml Outdated Show resolved Hide resolved
Comment on lines 12 to 18
kind: Dashboard
metadata:
name: Demo-2
project: default
createdAt: "2021-11-09T00:00:00Z"
updatedAt: "2021-11-09T00:00:00Z"
version: 0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has not been updated after 3a8e219. Now the resource is valid again. Same for the other dashboard resource.

@Nexucis
Copy link
Member

Nexucis commented Oct 8, 2024

Hey @basti1302 thank you for opening this PR !

Sorry for the long time to reply. We put this repository on pause for the moment because we are on other subjects that have a higher priority. So this operator is still working in progress and will stay like that until an unknown date.

So we are definitely looking for contribution to finish this operator ! I am just saying that in case you would like to do it :).

In the meantime @jgbernalp if you have some time to look at the PR, would be cool :).

Also @basti1302 I have ran the CI and it looks like there are some issues. Can you check it ? Thanks

@basti1302
Copy link
Contributor Author

Thanks for the update with regard to the state of this repository. Unfortunately I do not have the capacity to contribute significantly to this project.

The CI build issues are unrelated to this PR.

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xa[40](https://github.com/perses/perses-operator/actions/runs/11124716530/job/30958820291#step:5:41)aef]

IIRC this is a known bug either in the operator framework or some related dependency. Could be this one, not sure: operator-framework/operator-sdk#6230

Locally I bumped CONTROLLER_TOOLS_VERSIONfromv0.11.1tov0.14.0` to get the build working.

I can create a separate PR, however, that will also regenerate things in config, which is why I left these changes out of this PR.

@Nexucis
Copy link
Member

Nexucis commented Oct 8, 2024

no worries it was just in case Dash0 wanted to see it releases a bit sooner.

Thanks for checking @basti1302

@basti1302
Copy link
Contributor Author

I created a PR for updating the controller tools version here: #14

README.md Show resolved Hide resolved
@jgbernalp
Copy link
Contributor

LGTM, we can merge when the pipeline is fixed with #14

@Nexucis
Copy link
Member

Nexucis commented Oct 9, 2024

PR #14 has been merged. @basti1302 Can you rebase your PR to see if the build is passing ?

Thanks for your work here, that is super appreciated !

@basti1302
Copy link
Contributor Author

PR #14 has been merged. @basti1302 Can you rebase your PR to see if the build is passing ?

Thanks for your work here, that is super appreciated !

Rebased, you're welcome 👍

Copy link
Member

@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome !

@Nexucis Nexucis merged commit 0c98327 into perses:main Oct 9, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing steps in readme, outdated sample custom resources
3 participants