Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop python 3.7 support #255

Merged
merged 1 commit into from
Apr 29, 2024
Merged

drop python 3.7 support #255

merged 1 commit into from
Apr 29, 2024

Conversation

davidism
Copy link
Member

Python 3.7 is EOL. Set minimum version to 3.8, and remove compatibility code for lower versions.

Copy link
Member

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd left this in a while back even after EOL because we didn't think it cost us much tech debt to leave it in, but this PR shows there's a lot of little things to cleanup, so I'm personally 👍 on it.

This will also unlock:

@davidism
Copy link
Member Author

davidism commented Apr 29, 2024

Even if there aren't significant changes, supporting old versions still has a contribution/maintenance cost, as CI might go away, it might be hard to install an old version, contributors might have to understand differences they typically don't deal with, etc. Since we use python_requires metadata, old Pythons will continue to install the last supported version.

@davidism davidism merged commit c218bb1 into main Apr 29, 2024
10 checks passed
@davidism davidism deleted the drop-py37 branch April 29, 2024 16:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants