-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop unnecessary Blinker
dependency
#248
Conversation
Oh interesting, Python 3.7 requires Blinker... Probably newer Flasks require it, but Flask 2.2.0 doesn't... not worth tracking down, but essentially this PR is blocked until we drop Python 3.7 support.
|
Flask requires this, so it's a transitive dep, but it's not directly used within this toolbar at all. We do directly import the other listed packages, so they should stay.
e8545c9
to
677bf79
Compare
We dropped So this PR is unblocked... I've rebased it and it should be good to go. |
🤔 I wonder though... it seems the exception in #248 (comment) implies that we are directly relying on Blinker somehow... My guess is for signals, although I haven't tracked down whether FDBT is using signals all the time, or just in that particular test. Regardless, now that we've dropped Python |
I don't think we need any dependency except Flask itself. Declaring Flask's own dependencies here is redundant, and would presumably break anyway if Flask were to not depend on them anymore (not that it would do that). |
Flask requires this, so it's a transitive dep, but it's not directly used within this toolbar at all.
We do directly import the other listed packages, so they should stay.