Update jquery.tablesorter.js plugin
#235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
force-pushed
the
update-jquery-table-sorter
branch
5 times, most recently
from
4737f5f
to
e85abd4
Compare
jeffwidman
force-pushed
the
update-jquery-table-sorter
branch
3 times, most recently
from
f29a97a
to
72a56f2
Compare
Update to the latest `v2.31.3` version of this `jquery` plugin, which unblocks upgrading to `jquery` >= `1.9.x`. Using a fork because: 1. The original repo hasn't been updated in seven years: https://github.com/christianbach/tablesorter 2. The most recent committer to the original repo ☝️ now maintains the fork. 3. The fork was updated just a few months ago. 4. The fork supports the latest versions of `jquery`: > Works with jQuery 1.9+ (`$.browser.msie` was removed; needed in the original version) As far as I can tell, no other changes are needed. This is a straight copy/paste of the non-minized code from: https://github.com/Mottie/tablesorter I used non-minimized for simplicity, since this is a dev-only tool, the perf impacts of minimization don't really matter. I tested this manually by: ```shell $ cd flask-debugtoolbar/test $ flask --app basic_app run --debug ``` Then loading `http://127.0.0.1:5000/` in a recent version of Chrome and finding a FDBT panel that uses the sorter. In this case, the SQLAlchemy panel. I visually compared behavior pre/past upgrade and it appeared identical. Related: * #166
jeffwidman
force-pushed
the
update-jquery-table-sorter
branch
from
72a56f2
to
18a78df
Compare
greyli
approved these changes
Apr 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the latest
v2.31.3version of thisjqueryplugin, whichunblocks upgrading to
jquery>=1.9.x.Using a fork because:
jquery:As far as I can tell, no other changes are needed.
This is a straight copy/paste of the non-minized code from: https://github.com/Mottie/tablesorter
I used non-minimized for simplicity, since this is a dev-only tool, the
perf impacts of minimization don't really matter.
I tested this manually by:
$ cd flask-debugtoolbar/test $ flask --app basic_app run --debugThen loading
http://127.0.0.1:5000/in a recent version of Chrome andfinding a FDBT panel that uses the sorter. In this case, the SQLAlchemy
panel. I visually compared behavior pre/past upgrade and it appeared
identical.
Related: