Fix some jquery deprecation warnings
#242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greyli
approved these changes
Apr 12, 2024
|
Thanks for the quick review @greyli 👍 Since this is the final PR in a 🚂 of Jquery-related PR's, I'll hold off on merging this until these other PR's are reviewed/merged: |
Ths is a follow-on PR to #241 in order to fix the deprecation warnings: * `bind()` replaced by `on()` * `click(handler)` replaced by `on('click', handler)` Three deprecation warnings remain, but they are caused by the `jquery.tablesorter.js` plugin, so need to be handled upstream: * Mottie/tablesorter#1787 * Mottie/tablesorter#1786 Related: * #166
jeffwidman
force-pushed
the
bump-jquery-to-3.x
branch
from
93b8f0f
to
0fbbe0c
Compare
jeffwidman
force-pushed
the
fix-a-couple-of-jquery-deprecation-warnings
branch
from
1b38e19
to
2036b19
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ths is a follow-on PR to
#241 in order to fix the deprecation warnings:
bind()replaced byon()click(handler)replaced byon('click', handler)Three deprecation warnings remain, but they are caused by the
jquery.tablesorter.jsplugin, so need to be handled upstream:Related: