-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the missing install requirement packaging
#225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. To keep things easier for users do you want to release 0.14.1
even though this is a meta release to fix releasing 0.14.0?
Optionally do we care about the ordering of these packages? For example do we want to alphabetize them? I'm ok either way.
We do need to release
I don't think we need to care about the order. This |
If a release fails for something release related sometimes package authors will release Using After the new release is out, I do suggest we yank |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oof, good catch!
Please don't forget to include the actual text of the failure in your PR / commit description. Links to CI runs will go stale over time as those CI run logs expire. Also, please update your commit description to match the PR description so that when I do a squash merge I don't have to copy paste the description from the PR description. 😄 |
Also, for anyone blocked by this before we get a bugfix release out, the workaround is simple--just manually install |
We need a `0.14.1` release which will include the bugfix #225.
Sorry, will do it next time. I need to write a note on my desk :P Thanks for the quick action on 0.14.1! |
To prevent issues like pallets-eco#225, This PR add a minimal test that no extra deps are involved, it only install the package, then try to import the extension class. fixes pallets-eco#226
To prevent issues like pallets-eco#225, This PR add a minimal test that no extra deps are involved, it only install the package, then try to import the extension class. fixes pallets-eco#226
The
packaging
lib is not listed in theinstall_requires
list.https://github.com/greyli/flask-extension-status/actions/runs/7129071225/job/19412328108
We need to merge this and then make a fix release ASAP.