fix: use remove-signatures in skopeo copy stages #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to [1] neither Docker daemon nor OCI support storing the container signatures, and skopeo copy refuses to just silently drop them and fails. When using `skopeo copy --remove-signatures` to make the copy, the signatures will be still read and policy.json will still be enforced, they just won’t be written into the destination. [1] containers/skopeo#589 (comment) Resolves: THEEDGE-4032 Relates: RHEL-34807 Signed-off-by: Miguel Martín <[email protected]>
mmartinv
force-pushed
the
skopeo-copy-to-iso-remove-signatures
branch
from
852ba1b
to
fad8167
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to [1] neither Docker daemon nor OCI support storing
the container signatures, and skopeo copy refuses to just silently drop
them and fails.
When using
skopeo copy --remove-signaturesto make the copy, thesignatures will be still read and policy.json will still be enforced,
they just won’t be written into the destination.
[1] containers/skopeo#589 (comment)