Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disk image generation fails with signed containers #681

Closed
mmartinv opened this issue Oct 18, 2024 · 0 comments · Fixed by osbuild/images#990
Closed

Disk image generation fails with signed containers #681

mmartinv opened this issue Oct 18, 2024 · 0 comments · Fixed by osbuild/images#990

Comments

@mmartinv
Copy link
Contributor

mmartinv commented Oct 18, 2024

It's not possible to generate a qcow2 image from a signed container, the build fails with the following error:

org.osbuild.container-deploy: 3997d3ffea649b0f548b17edc3950b682bd3ea6b86551552fa580c1024db6b13 {}
Getting image source signatures
Checking if image destination supports signatures
time="2024-10-18T11:12:19Z" level=fatal msg="Copying this image would require changing layer representation, which we cannot do: \"Would invalidate signatures\""
Error: tmp-container-deploy-82752177721682: image not known
Traceback (most recent call last):
  File "/run/osbuild/bin/org.osbuild.container-deploy", line 50, in main
    subprocess.run(
  File "/usr/lib64/python3.12/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['skopeo', 'copy', 'containers-storage:[overlay@/run/osbuild/containers/storage+/run/containers/storage]a54573503344f1adafea48e1383aa4a339c39f0c065e7eec28e814652f12b3b1', 'containers-storage:tmp-container-deploy-82752177721682']' returned non-zero exit status 1.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/run/osbuild/bin/org.osbuild.container-deploy", line 64, in <module>
    r = main(args["inputs"], args["tree"], args["options"])
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/run/osbuild/bin/org.osbuild.container-deploy", line 47, in main
    with contextlib.ExitStack() as cm:
         ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/contextlib.py", line 610, in __exit__
    raise exc_details[1]
  File "/usr/lib64/python3.12/contextlib.py", line 595, in __exit__
    if cb(*exc_details):
       ^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/contextlib.py", line 478, in _exit_wrapper
    callback(*args, **kwds)
  File "/usr/lib64/python3.12/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['podman', 'rmi', 'tmp-container-deploy-82752177721682']' returned non-zero exit status 1.

Similar to #676

mmartinv added a commit to mmartinv/osbuild-images that referenced this issue Oct 18, 2024
Make `skopeo copy` to remove the signatures of signed containers
by default to avoid build failures.

Depends: osbuild/osbuild#1906
Resolves: osbuild/bootc-image-builder/issues/681

Signed-off-by: Miguel Martín <[email protected]>
mmartinv added a commit to mmartinv/osbuild-images that referenced this issue Oct 22, 2024
Make `skopeo copy` to remove the signatures of signed containers
by default to avoid build failures until [1] is implemented.

Depends: osbuild/osbuild#1906
Resolves: osbuild/bootc-image-builder#681

[1] containers/image#2599

Signed-off-by: Miguel Martín <[email protected]>
mmartinv added a commit to mmartinv/osbuild-images that referenced this issue Oct 22, 2024
Make `skopeo copy` to remove the signatures of signed containers
by default to avoid build failures until [1] is implemented.

Depends: osbuild/osbuild#1906
Resolves: osbuild/bootc-image-builder#681

[1] containers/image#2599

Signed-off-by: Miguel Martín <[email protected]>
mmartinv added a commit to mmartinv/osbuild-images that referenced this issue Oct 22, 2024
Make `skopeo copy` to remove the signatures of signed containers
by default to avoid build failures until [1] is implemented.

Depends: osbuild/osbuild#1906
Resolves: osbuild/bootc-image-builder#681

[1] containers/image#2599

Signed-off-by: Miguel Martín <[email protected]>
mmartinv added a commit to mmartinv/osbuild-images that referenced this issue Oct 25, 2024
Make `skopeo copy` to remove the signatures of signed containers
by default to avoid build failures until [1] is implemented.

Depends: osbuild/osbuild#1906
Resolves: osbuild/bootc-image-builder#681

[1] containers/image#2599

Co-authored-by: Michael Vogt <[email protected]>
mmartinv added a commit to mmartinv/osbuild-images that referenced this issue Oct 29, 2024
Make `skopeo copy` to remove the signatures of signed containers
by default to avoid build failures until [1] is implemented.

Depends: osbuild/osbuild#1906
Resolves: osbuild/bootc-image-builder#681

[1] containers/image#2599

Co-authored-by: Michael Vogt <[email protected]>
github-merge-queue bot pushed a commit to osbuild/images that referenced this issue Oct 30, 2024
Make `skopeo copy` to remove the signatures of signed containers
by default to avoid build failures until [1] is implemented.

Depends: osbuild/osbuild#1906
Resolves: osbuild/bootc-image-builder#681

[1] containers/image#2599

Co-authored-by: Michael Vogt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant