Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make use of new stops+stations layer #1284

Merged
merged 3 commits into from
Oct 18, 2024
Merged

make use of new stops+stations layer #1284

merged 3 commits into from
Oct 18, 2024

Conversation

miles-grant-ibigroup
Copy link
Collaborator

Description:
Waiting for otp-ui

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

@miles-grant-ibigroup miles-grant-ibigroup self-assigned this Oct 11, 2024
@miles-grant-ibigroup miles-grant-ibigroup mentioned this pull request Oct 17, 2024
Merged
@miles-grant-ibigroup miles-grant-ibigroup marked this pull request as ready for review October 18, 2024 12:45
amy-corson-ibigroup
amy-corson-ibigroup approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful stations! I don't think this is blocking but just flagging that hovering the corresponding card in the nearby view isn't hilighting the new station circle, which maybe something we want to fix in the future.

@miles-grant-ibigroup miles-grant-ibigroup mentioned this pull request Oct 18, 2024
Open
josh-willis-arcadis
josh-willis-arcadis approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely!

@miles-grant-ibigroup miles-grant-ibigroup merged commit 98467b5 into dev Oct 18, 2024
9 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the stops-and-stations-layer branch October 18, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amy-corson-ibigroup amy-corson-ibigroup amy-corson-ibigroup approved these changes

@josh-willis-arcadis josh-willis-arcadis josh-willis-arcadis approved these changes

Assignees

@miles-grant-ibigroup miles-grant-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miles-grant-ibigroup @amy-corson-ibigroup @josh-willis-arcadis