fix: add combined stops/stations layer #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-corson-ibigroup
requested changes
Oct 17, 2024
| endpoint: string, | ||
| setLocation?: (location: MapLocationActionArg) => void, | ||
| setViewedStop?: (stop: Stop) => void, | ||
| stopsWhitelist?: string[], | ||
| configCompanies?: ConfiguredCompany[], | ||
| getEntityPrefix?: (entity: Stop | Station) => JSX.Element | ||
| ): JSX.Element[] => { | ||
| const fakeOtpUiLayerIndex = layers.findIndex(l=>l.type === STOPS_AND_STATIONS_TYPE) |
There was a problem hiding this comment.
Can you add a comment here explaining why we're calling this fakeOtpUiLayerIndex
There was a problem hiding this comment.
It's not a real layer! The others are all linked to actual maplibre layers
|
Bug you mention is fixed here! opentripplanner/otp-react-redux#1284 |
amy-corson-ibigroup
approved these changes
Oct 17, 2024
josh-willis-arcadis
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires a few hacks to get click handling working, but allows us to render stations/stops seamless as one layer