-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DataTable to fix bug with search input #42
Open
Ana06
wants to merge
1
commit into
openSUSE:master
Choose a base branch
from
Ana06:datatables
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,8 +5,10 @@ | |
description: A `%div` container with the CSS class `.table-responsive` makes the table responsive. The width of columns can be adjusted by using the | ||
[Bootstrap's sizing classes](https://getbootstrap.com/docs/4.1/utilities/sizing/) on the `%th` tags | ||
([Bootstrap's grid system](https://getbootstrap.com/docs/4.1/layout/grid/) doesn't work for tables in Chrome). | ||
Additionally, we are using [DataTable](https://datatables.net/examples/styling/bootstrap4)'s [responsive](https://datatables.net/extensions/responsive/) | ||
and style them with striped rows (`.table-striped`) and borders (`.table-bordered`). However, you can use tables with and without datatables. | ||
Additionally, you can also use [DataTable](https://datatables.net/examples/styling/bootstrap4)'. | ||
Style it with striped rows (`.table-striped`) and borders (`.table-bordered`). | ||
Do not forget to initialize it with `initializeDataTable()` and to wrap it inside the class `.obs-dataTable`, | ||
as this is solving a [bug related to the search field not being resposive](https://github.com/mkhairi/jquery-datatables/issues/14). | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's a typo here: not being responsive |
||
--- | ||
|
||
%h5 Table | ||
|
@@ -34,27 +36,26 @@ | |
|
||
%h5 Table with DataTable | ||
|
||
%table.responsive.table.table-striped.table-bordered#my-datatable | ||
%thead | ||
%tr | ||
%th Fruits | ||
%th Origin | ||
%th Vendor | ||
%tbody | ||
%tr | ||
%td Oranges | ||
%td Bananas | ||
%td Kiwis | ||
%tr | ||
%td Spain | ||
%td Brazil | ||
%td Germany | ||
%tr | ||
%td Fruits Are Us | ||
%td Fruits & Vegetables Inc. | ||
%td SUSE Fruit Company Ltd. | ||
.obs-dataTable | ||
Ana06 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
%table.table.table-striped.table-bordered#my-datatable | ||
%thead | ||
%tr | ||
%th Fruits | ||
%th Origin | ||
%th Vendor | ||
%tbody | ||
%tr | ||
%td Oranges | ||
%td Bananas | ||
%td Kiwis | ||
%tr | ||
%td Spain | ||
%td Brazil | ||
%td Germany | ||
%tr | ||
%td Fruits Are Us | ||
%td Fruits & Vegetables Inc. | ||
%td SUSE Fruit Company Ltd. | ||
|
||
:javascript | ||
$('#my-datatable').DataTable({ | ||
responsive: true | ||
}); | ||
= content_for :ready_function do | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should still be |
||
initializeDataTable('#my-datatable'); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence seems out of place now. Do we still need it? I don't believe so.