Update DataTable to fix bug with search input #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for obs-patterns failed. Built with commit 48d83d2 https://app.netlify.com/sites/obs-patterns/deploys/5c0536270097d4092d7679f0 |
dmarcoux
suggested changes
Nov 30, 2018
This was referenced Nov 30, 2018
dmarcoux
reviewed
Dec 3, 2018
| Additionally, you can also use [DataTable](https://datatables.net/examples/styling/bootstrap4)'. | ||
| Style it with striped rows (`.table-striped`) and borders (`.table-bordered`). | ||
| Do not forget to initialize it with `initializeDataTable()` and to wrap it inside the class `.obs-dataTable`, | ||
| as this is solving a [bug related to the search field not being resposive](https://github.com/mkhairi/jquery-datatables/issues/14). |
There was a problem hiding this comment.
There's a typo here: not being responsive
dmarcoux
reviewed
Dec 3, 2018
| @@ -5,8 +5,10 @@ | |||
| description: A `%div` container with the CSS class `.table-responsive` makes the table responsive. The width of columns can be adjusted by using the | |||
| [Bootstrap's sizing classes](https://getbootstrap.com/docs/4.1/utilities/sizing/) on the `%th` tags | |||
| ([Bootstrap's grid system](https://getbootstrap.com/docs/4.1/layout/grid/) doesn't work for tables in Chrome). | |||
| Additionally, we are using [DataTable](https://datatables.net/examples/styling/bootstrap4)'s [responsive](https://datatables.net/extensions/responsive/) | |||
| and style them with striped rows (`.table-striped`) and borders (`.table-bordered`). However, you can use tables with and without datatables. | |||
| Additionally, you can also use [DataTable](https://datatables.net/examples/styling/bootstrap4)'. | |||
There was a problem hiding this comment.
This sentence seems out of place now. Do we still need it? I don't believe so.
dmarcoux
reviewed
Dec 3, 2018
| $('#my-datatable').DataTable({ | ||
| responsive: true | ||
| }); | ||
| = content_for :ready_function do |
There was a problem hiding this comment.
This should still be :javascript as content_for doesn't work in Jekyll
|
@Ana06 ping! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This need openSUSE/open-build-service#6410 to get merged